fix(chromium): make locale overrides work (#1108)

microsoft · Feb 26, 2020 · 4f69930 · 4f69930
1 parent 3afaeef
commit 4f69930
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/chromium/crPage.ts b/src/chromium/crPage.ts
@@ -112,6 +112,8 @@ export class CRPage implements PageDelegate {
       promises.push(this._client.send('Emulation.setScriptExecutionDisabled', { value: true }));
     if (options.userAgent || options.locale)
       promises.push(this._client.send('Emulation.setUserAgentOverride', { userAgent: options.userAgent || '', acceptLanguage: options.locale }));
+    if (options.locale)
+      promises.push(this._client.send('Emulation.setLocaleOverride', { locale: options.locale }));
     if (options.timezoneId)
       promises.push(emulateTimezone(this._client, options.timezoneId));
     if (options.geolocation)

diff --git a/test/emulation.spec.js b/test/emulation.spec.js
@@ -253,7 +253,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF
     });
   });
 
-  describe.skip(CHROMIUM || FFOX)('BrowserContext({locale})', function() {
+  describe.skip(FFOX)('BrowserContext({locale})', function() {
     it('should affect accept-language header', async({browser, server}) => {
       const context = await browser.newContext({ locale: 'fr-CH' });
       const page = await context.newPage();