Skip to content

Commit

Permalink
pavel comments
Browse files Browse the repository at this point in the history
  • Loading branch information
JoelEinbinder committed Jul 12, 2021
1 parent 361513c commit 7aa008f
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docs/src/api/class-frame.md
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ Optional event-specific initialization properties.

### option: Frame.dragAndDrop.timeout = %%-input-timeout-%%

### option: Frame.dragAndDrop.timeout = %%-input-trial-%%
### option: Frame.dragAndDrop.trial = %%-input-trial-%%

## async method: Frame.evalOnSelector
* langs:
Expand Down
2 changes: 1 addition & 1 deletion docs/src/api/class-page.md
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@ Optional event-specific initialization properties.

### option: Page.dragAndDrop.timeout = %%-input-timeout-%%

### option: Page.dragAndDrop.timeout = %%-input-trial-%%
### option: Page.dragAndDrop.trial = %%-input-trial-%%

## async method: Page.emulateMedia

Expand Down
10 changes: 8 additions & 2 deletions src/server/frames.ts
Original file line number Diff line number Diff line change
Expand Up @@ -989,13 +989,19 @@ export class Frame extends SdkObject {
return handle._retryPointerAction(progress, 'move and down', false, async point => {
await this._page.mouse.move(point.x, point.y);
await this._page.mouse.down();
}, options);
}, {
...options,
timeout: progress.timeUntilDeadline(),
});
}));
await dom.assertDone(await this._retryWithProgressIfNotConnected(progress, selector2, async handle => {
return handle._retryPointerAction(progress, 'move and up', false, async point => {
await this._page.mouse.move(point.x, point.y);
await this._page.mouse.up();
}, options);
}, {
...options,
timeout: progress.timeUntilDeadline(),
});
}));
}, this._page._timeoutSettings.timeout(options));
}
Expand Down

0 comments on commit 7aa008f

Please sign in to comment.