Skip to content

Commit

Permalink
devops: try to use azure/docker-login instead of manual login (#3714)
Browse files Browse the repository at this point in the history
Manual login appeared to be successful, but rejected docker push.

References #2926
  • Loading branch information
aslushnikov authored Sep 1, 2020
1 parent fad840d commit ba7093c
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions .github/workflows/publish_canary_docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,23 @@ jobs:
if: github.repository == 'microsoft/playwright'
steps:
- uses: actions/checkout@v2
- uses: azure/docker-login@v1
with:
login-server: playwright.azurecr.io
username: playwright
password: ${{ secrets.DOCKER_PASSWORD }}
- uses: actions/setup-node@v1
with:
node-version: 10.15
- run: npm ci
- run: npm run build
- name: login & publish to docker
- name: docker: build & publish
run: |
# login to docker
docker login --username playwright --password ${{ secrets.DOCKER_PASSWORD }} playwright.azurecr.io
# build docker image
./docs/docker/build.sh
# tag image accordingly
docker tag playwright:localbuild public/playwright:next
docker tag playwright:localbuild public/playwright:sha-$(git rev-parse HEAD)
docker tag playwright:localbuild public/playwright:sha-${{ github.sha }}
docker rmi playwright:localbuild
# push image to registry
docker push public/playwright:next
Expand Down

0 comments on commit ba7093c

Please sign in to comment.