Skip to content

Commit

Permalink
browser(webkit): roll webkit to 1213 (#2045)
Browse files Browse the repository at this point in the history
  • Loading branch information
pavelfeldman authored Apr 30, 2020
1 parent 78b44ed commit c55db6d
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 25 deletions.
2 changes: 1 addition & 1 deletion browsers.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
{
"name": "webkit",
"revision": "1211"
"revision": "1213"
}
]
}
2 changes: 1 addition & 1 deletion packages/playwright-webkit/browsers.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"browsers": [
{
"name": "webkit",
"revision": "1211"
"revision": "1213"
}
]
}
2 changes: 1 addition & 1 deletion packages/playwright/browsers.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
{
"name": "webkit",
"revision": "1211"
"revision": "1213"
}
]
}
2 changes: 1 addition & 1 deletion src/webkit/wkPage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -762,7 +762,7 @@ export class WKPage implements PageDelegate {
}

async setActivityPaused(paused: boolean): Promise<void> {
// await this._session.send('Page.setJavaScriptPaused', { paused });
await this._session.send('Page.setActivityPaused', { paused });
}

async getContentQuads(handle: dom.ElementHandle): Promise<types.Quad[] | null> {
Expand Down
26 changes: 5 additions & 21 deletions test/click.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@ describe('Page.click', function() {
expect(await page.evaluate(() => window.clicked)).toBe(undefined);
expect(error.message).toBe('waiting for element to receive pointer events failed: timeout exceeded');
});
it.fail(CHROMIUM || WEBKIT || FFOX)('should work when element jumps uncontrollably', async({page, server}) => {
it.fail(CHROMIUM || FFOX)('should work when element jumps uncontrollably', async({page, server}) => {
// This test requires pausing the page.
await page.goto(server.PREFIX + '/input/animating-button.html');
await page.evaluate(() => addButton());
Expand All @@ -612,23 +612,7 @@ describe('Page.click', function() {
expect(clicked).toBe(true);
expect(await page.evaluate(() => window.clicked)).toBe(true);
});
it.fail(CHROMIUM || WEBKIT || FFOX)('should wait while element is blocked on hover', async({page, server}) => {
// This test requires pausing the page.
await page.setContent(`<style>
@keyframes move-out { from { marign-left: 0; } to { margin-left: 150px; } }
container { display: block; position: relative; width: 200px; height: 50px; }
div, button { position: absolute; left: 0; top: 0; bottom: 0; right: 0; }
div { pointer-events: none; }
container:hover div { pointer-events: auto; background: red; animation: 3s linear move-out; animation-fill-mode: forwards; }
</style>
<container>
<button onclick="window.clicked=true">Click me</button>
<div></div>
</container>`);
await page.click('button');
expect(await page.evaluate(() => window.clicked)).toBe(true);
});
it.fail(CHROMIUM || WEBKIT || FFOX)('should pause animations', async({page}) => {
it.fail(CHROMIUM || FFOX)('should pause animations', async({page}) => {
// This test requires pausing the page.
await page.setContent(`<style>
@keyframes spinner {
Expand All @@ -648,7 +632,7 @@ describe('Page.click', function() {
await page.click('#target', { __testHookSkipStablePosition: new Promise(f => setTimeout(f, 100)) });
expect(await page.evaluate(() => window.clicked)).toBe(true);
});
it.fail(CHROMIUM || WEBKIT || FFOX)('should defer timers', async({page}) => {
it.fail(CHROMIUM || FFOX)('should defer timers', async({page}) => {
// This test requires pausing the page.
await page.setContent(`<button id=button onclick="window.clicked=true">Click me</button>`);
await page.click('button', { __testHookSkipStablePosition: async () => {
Expand All @@ -659,7 +643,7 @@ describe('Page.click', function() {
}});
expect(await page.evaluate(() => window.clicked)).toBe(true);
});
it.fail(CHROMIUM || WEBKIT || FFOX)('should defer rafs', async({page}) => {
it.fail(CHROMIUM || FFOX)('should defer rafs', async({page}) => {
// This test requires pausing the page.
await page.setContent(`<button id=button onclick="window.clicked=true">Click me</button>`);
await page.click('button', { __testHookSkipStablePosition: async () => {
Expand All @@ -670,7 +654,7 @@ describe('Page.click', function() {
}});
expect(await page.evaluate(() => window.clicked)).toBe(true);
});
it.fail(CHROMIUM || WEBKIT || FFOX)('should defer fetch', async({page, server}) => {
it.fail(CHROMIUM || FFOX)('should defer fetch', async({page, server}) => {
// This test requires pausing the page.
await page.goto(server.EMPTY_PAGE);
await page.setContent(`<button id=button onclick="window.clicked=true">Click me</button>`);
Expand Down

0 comments on commit c55db6d

Please sign in to comment.