Skip to content

Commit

Permalink
test: mark a few tests as fixme (#32985)
Browse files Browse the repository at this point in the history
  • Loading branch information
dgozman authored Oct 7, 2024
1 parent 001ba37 commit e6afb65
Show file tree
Hide file tree
Showing 9 changed files with 20 additions and 7 deletions.
2 changes: 1 addition & 1 deletion tests/config/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export function expectedSSLError(browserName: string, platform: string): RegExp
else if (platform === 'win32')
return /SSL peer certificate or SSH remote key was not OK/;
else
return /Unacceptable TLS certificate/;
return /Unacceptable TLS certificate|Operation was cancelled/;
}
return /SSL_ERROR_UNKNOWN/;
}
Expand Down
4 changes: 3 additions & 1 deletion tests/library/browsercontext-viewport.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,9 @@ browserTest('should report null viewportSize when given null viewport', async ({
await context.close();
});

browserTest('should drag with high dpi', async ({ browser, server }) => {
browserTest('should drag with high dpi', async ({ browser, server, headless }) => {
browserTest.fixme(!headless, 'Flaky on all browser in headed');

const page = await browser.newPage({ deviceScaleFactor: 2 });
await page.goto(server.PREFIX + '/drag-n-drop.html');
await page.hover('#source');
Expand Down
1 change: 1 addition & 0 deletions tests/library/page-clock.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,7 @@ it.describe('popup', () => {
page.waitForEvent('popup'),
page.evaluate(url => window.open(url), server.PREFIX + '/popup.html'),
]);
await popup.waitForLoadState();
const popupTime = await popup.evaluate('time');
expect(popupTime).toBe(1000);
});
Expand Down
2 changes: 2 additions & 0 deletions tests/page/expect-misc.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,8 @@ test.describe('toBeInViewport', () => {
});

test('should respect ratio option', async ({ page, isAndroid }) => {
test.fixme(isAndroid, 'ratio 0.24 is not in viewport for unknown reason');

await page.setContent(`
<style>body, div, html { padding: 0; margin: 0; }</style>
<div id=big style="height: 400vh;"></div>
Expand Down
3 changes: 2 additions & 1 deletion tests/page/frame-goto.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,9 @@ it('should reject when frame detaches', async ({ page, server, browserName }) =>
expect(error.message.toLowerCase()).toContain('frame was detached');
});

it('should continue after client redirect', async ({ page, server, isAndroid, mode }) => {
it('should continue after client redirect', async ({ page, server, isAndroid, browserName }) => {
it.fixme(isAndroid);
it.fixme(browserName === 'firefox', 'script.js is requested before navigationCommitted arrives');

server.setRoute('/frames/script.js', () => {});
const url = server.PREFIX + '/frames/child-redirect.html';
Expand Down
3 changes: 2 additions & 1 deletion tests/page/interception.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,9 @@ it('should intercept network activity from worker', async function({ page, serve

it('should intercept worker requests when enabled after worker creation', {
annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/32355' }
}, async ({ page, server, isAndroid, browserName }) => {
}, async ({ page, server, isAndroid, browserName, browserMajorVersion }) => {
it.skip(isAndroid);
it.skip(browserName === 'chromium' && browserMajorVersion < 130, 'fixed in Chromium 130');

await page.goto(server.EMPTY_PAGE);
server.setRoute('/data_for_worker', (req, res) => res.end('failed to intercept'));
Expand Down
4 changes: 3 additions & 1 deletion tests/page/locator-misc-1.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ it('should hover @smoke', async ({ page, server }) => {
expect(await page.evaluate(() => document.querySelector('button:hover').id)).toBe('button-6');
});

it('should hover when Node is removed', async ({ page, server }) => {
it('should hover when Node is removed', async ({ page, server, headless }) => {
it.skip(!headless, 'headed messes up with hover');

await page.goto(server.PREFIX + '/input/scrollable.html');
await page.evaluate(() => delete window['Node']);
const button = page.locator('#button-6');
Expand Down
4 changes: 3 additions & 1 deletion tests/page/page-click.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ it('should not throw UnhandledPromiseRejection when page closes', async ({ page,
]).catch(e => {});
});

it('should click the 1x1 div', async ({ page }) => {
it('should click the 1x1 div', async ({ page, browserName, isWindows }) => {
it.fixme(browserName === 'firefox' && isWindows, 'always times out');

await page.setContent(`<div style="width: 1px; height: 1px;" onclick="window.__clicked = true"></div>`);
await page.click('div');
expect(await page.evaluate('window.__clicked')).toBe(true);
Expand Down
4 changes: 3 additions & 1 deletion tests/page/page-request-fulfill.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,10 @@ it('should fetch original request and fulfill', async ({ page, server, isElectro
expect(await page.title()).toEqual('Woof-Woof');
});

it('should fulfill with multiple set-cookie', async ({ page, server, isElectron, electronMajorVersion }) => {
it('should fulfill with multiple set-cookie', async ({ page, server, isElectron, electronMajorVersion, isAndroid }) => {
it.skip(isElectron && electronMajorVersion < 14, 'Electron 14+ is required');
it.skip(isAndroid, 'Android does not have an isolated context per test, so we get cookies from other tests');

const cookies = ['a=b', 'c=d'];
await page.route('**/multiple-set-cookie.html', async route => {
void route.fulfill({
Expand Down

0 comments on commit e6afb65

Please sign in to comment.