Skip to content

Commit

Permalink
devops: revision Chromium repackaged builds separately (#3698)
Browse files Browse the repository at this point in the history
Currently, we mirror Chromium revisions from gbuckets to our cdn and
name them same way as Chromium revision.

However, with the upcoming bundling of FFMPEG, we'd like to revision
Chromium packages separately, since our Chromium package will depend from
a number of factors:
- chromium upstream revision
- ffmpeg version
- extra files to add to the package or remove from the package

We should be able to produce a new Chromium build once any of these changes.

With this patch, to roll Chromium browser:
- update chromium revision number in the
`//browser_patches/chromium/UPSTREAM_CONFIG.sh`
- bump the build number in the `//browser_patches/chromium/BUILD_NUMBER`

Reference #3680
  • Loading branch information
aslushnikov authored Aug 31, 2020
1 parent 8f37d78 commit fcc1680
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion browser_patches/chromium/BUILD_NUMBER
Original file line number Diff line number Diff line change
@@ -1 +1 @@
799610
1000
1 change: 1 addition & 0 deletions browser_patches/chromium/UPSTREAM_CONFIG.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
UPSTREAM_CHROMIUM_REVISION=792639
5 changes: 3 additions & 2 deletions browser_patches/chromium/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,11 @@ set +x
trap "cd $(pwd -P)" EXIT
cd "$(dirname $0)"

source "./UPSTREAM_CONFIG.sh"

mkdir -p output
cd output

BUILD_NUMBER=$(head -1 ../BUILD_NUMBER)
FOLDER_NAME=""
ZIP_NAME=""
FILES_TO_REMOVE=()
Expand All @@ -32,7 +33,7 @@ else
exit 1
fi

URL="https://storage.googleapis.com/chromium-browser-snapshots/${FOLDER_NAME}/${BUILD_NUMBER}/${ZIP_NAME}"
URL="https://storage.googleapis.com/chromium-browser-snapshots/${FOLDER_NAME}/${UPSTREAM_CHROMIUM_REVISION}/${ZIP_NAME}"
curl --output upstream.zip "${URL}"

unzip upstream.zip
Expand Down

0 comments on commit fcc1680

Please sign in to comment.