Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] extract-zip fails npm audit #1510

Closed
aslushnikov opened this issue Mar 24, 2020 · 3 comments · Fixed by #1696
Closed

[BUG] extract-zip fails npm audit #1510

aslushnikov opened this issue Mar 24, 2020 · 3 comments · Fixed by #1696
Assignees
@aslushnikov

Comments

@aslushnikov
Copy link
Collaborator

We currently rely on extract-zip package to extract zip archives. The package, however, has not been maintained and currently raises unfortunate errors.

See max-mapper/extract-zip#85

extract-zip is a thin wrapper atop of yauzl - we should probably use that directly.
@aslushnikov aslushnikov self-assigned this Mar 24, 2020
@aslushnikov
Copy link
Collaborator Author

Hey @ABuffSeagull!

I saw your PR to Puppeteer regarding extract-zip: puppeteer/puppeteer#5526
We're actually interested in this PR at Playwright as well. Would you like to contribute?

@ABuffSeagull
Copy link

Absolutely! Just need to figure out one last problem on in puppeteer first, and then I'll look over this.

ABuffSeagull added a commit to ABuffSeagull/playwright that referenced this issue Mar 25, 2020
@ABuffSeagull
chore: Replace extract-zip with yauzl-promise
8647257 
Since extract-zip is abandonware, remove it and just work with
yauzl directly.

Fixes microsoft#1510
ABuffSeagull added a commit to ABuffSeagull/playwright that referenced this issue Mar 25, 2020
@ABuffSeagull
chore: Replace extract-zip with yauzl-promise
fac9655 
Since extract-zip is abandonware, remove it and just work with
yauzl directly.

Fixes microsoft#1510
@ABuffSeagull ABuffSeagull mentioned this issue Mar 25, 2020
Closed
ABuffSeagull added a commit to ABuffSeagull/playwright that referenced this issue Apr 2, 2020
@ABuffSeagull
chore: Replace extract-zip with yauzl-promise
a22f5f4 
Since extract-zip is abandonware, remove it and just work with
yauzl directly.

Fixes microsoft#1510
@pavelfeldman pavelfeldman added the v1 label Apr 4, 2020
ABuffSeagull added a commit to ABuffSeagull/playwright that referenced this issue Apr 7, 2020
@ABuffSeagull
chore: Replace extract-zip with yauzl-promise
59d0823 
Since extract-zip is abandonware, remove it and just work with
yauzl directly.

Fixes microsoft#1510
@aslushnikov
Copy link
Collaborator Author

For the record: we require all the fancy corner cases logic in extract-zip to handle symlinks properly. So we don't save much using raw yauzl instead of extract-zip.

aslushnikov added a commit to aslushnikov/playwright that referenced this issue Apr 7, 2020
@aslushnikov
chore: bump extract-zip dependency
46a5e8e 
Fixes microsoft#1510
@aslushnikov aslushnikov mentioned this issue Apr 7, 2020
Merged
aslushnikov added a commit that referenced this issue Apr 7, 2020
@aslushnikov
chore: bump extract-zip dependency (#1696)
949dc7b 
Fixes #1510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslushnikov aslushnikov

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@aslushnikov @pavelfeldman @ABuffSeagull