-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] implement happy eyeballs for API testing #18790
Labels
Comments
yury-s
added a commit
to yury-s/playwright
that referenced
this issue
Nov 14, 2022
…rosoft#18636)" The new node resolves loalhost to ::1 by default which breaks API tests in the ports (Java in particular). Reverting to the previous LTS to allow some time to implement happy eyeball algortithm on our end by next release. This reverts commit 63a0b75. Reference microsoft#18790
yury-s
added a commit
to yury-s/playwright
that referenced
this issue
Nov 14, 2022
…ecent Node.js LTS version (microsoft#18… …636)" The new node resolves loalhost to ::1 by default which breaks API tests in the ports (Java in particular). Reverting to the previous LTS to allow some time to implement happy eyeballs algorithm on our end by next release. This reverts commit 63a0b75. Reference microsoft#18790
yury-s
added a commit
that referenced
this issue
Nov 14, 2022
#18794) …e.js LTS version (#18636)" The new node resolves loalhost to ::1 by default which breaks API tests in the ports (Java in particular). Reverting to the previous LTS to allow some time to implement happy eyeballs algorithm on our end by next release. This reverts commit 63a0b75. Reference #18790
yury-s
added a commit
that referenced
this issue
Jan 5, 2023
mxschmitt
pushed a commit
that referenced
this issue
Jan 25, 2023
Since #18790 is merged and got released in 1.30 we can merge this now. Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After switching from Node.js 16 to 18 API tests started failing in Java because it only binds ipv4 127.0.0.1 and node resolves localhost to ::1 by default. To mitigate that we'd like to implement happy eyeballs on our end before node itself fixes it (see nodejs/node#41625).
The text was updated successfully, but these errors were encountered: