Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Browsers not installing on Node 14 #1988

Closed
corbinu opened this issue Apr 26, 2020 · 4 comments
Closed

[BUG] Browsers not installing on Node 14 #1988

corbinu opened this issue Apr 26, 2020 · 4 comments

Comments

@corbinu
Copy link

corbinu commented Apr 26, 2020

Context:

  • Playwright Version: 0.15.0
  • Operating System: Windows

Describe the bug

I just upgraded to the new Node 14 and with both npm and yarn the .local-browsers folder ends up empty on install. I was on Node 13 before and was fine. I just switched back to Node 12 and it works fine again.

@rwoll
Copy link
Member

rwoll commented Apr 27, 2020

This looks like it is likely related to max-mapper/extract-zip#94. extract-zip is a dependency of the browser fetcher script:

import * as extract from 'extract-zip';


Homebrew upgraded my environment to Node 14.0.0 surfacing this issue. As a temporary work around, I've brew install node@12.

@aslushnikov
Copy link
Contributor

Looks like this will be fixed with Node.js 14.1.0

@rwoll
Copy link
Member

rwoll commented Apr 30, 2020

Node 14.1.0 is now available.

I've confirmed that playwright@0.15.0 install cleanly in Node 14.1.0 on macOS. (@corbinu If you're still wanting to upgrade to node 14, does the latest release of Node resolve the issue for you on Windows?)

$ node --version
v14.1.0

$ npm i --save playwright

> playwright@0.15.0 install /Users/pw/Desktop/playwright-download/node_modules/playwright
> node install.js

Downloading chromium for playwright v0.15.0 - 124.3 Mb [====================] 100% 0.0s 
chromium for playwright v0.15.0 downloaded to /Users/pw/Desktop/playwright-download/node_modules/playwright/.local-browsers/chromium
Downloading firefox for playwright v0.15.0 - 68.9 Mb [====================] 100% 0.0s 
firefox for playwright v0.15.0 downloaded to /Users/pw/Desktop/playwright-download/node_modules/playwright/.local-browsers/firefox
Downloading webkit for playwright v0.15.0 - 47.1 Mb [====================] 100% 0.0s 
webkit for playwright v0.15.0 downloaded to /Users/pw/Desktop/playwright-download/node_modules/playwright/.local-browsers/webkit
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN playwright-download@1.0.0 No description
npm WARN playwright-download@1.0.0 No repository field.

+ playwright@0.15.0
added 38 packages from 81 contributors and audited 48 packages in 20.332s

2 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

$ ls -la ./node_modules/playwright/.local-browsers/
total 0
drwxr-xr-x   5 pw  staff  160 Apr 30 08:47 .
drwxr-xr-x   8 pw  staff  256 Apr 30 08:47 ..
drwxr-xr-x   3 pw  staff   96 Apr 30 08:47 chromium
drwxr-xr-x   3 pw  staff   96 Apr 30 08:47 firefox
drwxr-xr-x  16 pw  staff  512 Apr 30 08:47 webkit

@corbinu
Copy link
Author

corbinu commented Apr 30, 2020

@rwoll Confirmed it is now installing correctly on my Mac, Windows and Ubuntu machines! Thanks!

@corbinu corbinu closed this as completed Apr 30, 2020
hippee-lee added a commit to hippee-lee/clarity that referenced this issue Jul 13, 2021
microsoft/playwright#1988
microsoft/playwright#4033 (comment)

bumped the gh actions node version b/c of above

Signed-off-by: Matt Hippely <mhippely@vmware.com>
hippee-lee added a commit to hippee-lee/clarity that referenced this issue Jul 13, 2021
microsoft/playwright#1988
microsoft/playwright#4033 (comment)

bumped the gh actions node version b/c of above

Signed-off-by: Matt Hippely <mhippely@vmware.com>
hippee-lee added a commit to hippee-lee/clarity that referenced this issue Jul 13, 2021
Note: I'm changing the build workflow node version in the commit also to
address the re-occuring and intermittent issues with builds failing b/c
of playwright not being downloaded. Read more at these issues:
microsoft/playwright#1988
microsoft/playwright#4033 (comment)

Signed-off-by: Matt Hippely <mhippely@vmware.com>
hippee-lee added a commit to vmware-archive/clarity that referenced this issue Jul 14, 2021
Note: I'm changing the build workflow node version in the commit also to
address the re-occuring and intermittent issues with builds failing b/c
of playwright not being downloaded. Read more at these issues:
microsoft/playwright#1988
microsoft/playwright#4033 (comment)

Signed-off-by: Matt Hippely <mhippely@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants