Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Question] waitForSelector default - attached vs visible #2090

Closed
thernstig opened this issue May 4, 2020 · 2 comments
Closed

[Question] waitForSelector default - attached vs visible #2090

thernstig opened this issue May 4, 2020 · 2 comments

Comments

@thernstig
Copy link
Contributor

This is a curiosity thing.

How come attached is the default for waitForSelector, and not visible?

I would have guessed visible would be the most common default to want, but I might be entirely incorrect in that assumption.
@pavelfeldman pavelfeldman mentioned this issue May 4, 2020
Merged
@pavelfeldman
Copy link
Member

We liked the idea.

@aesyondu
Copy link
Contributor

aesyondu commented May 5, 2020

Same. I almost always add waitFor: "visible" in my waitForSelectors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pavelfeldman @thernstig @aesyondu