api(waitForSelector): make "state: visible" default, includes rename #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
changed the title
yury-s
approved these changes
May 4, 2020
| await page.goto(server.EMPTY_PAGE); | ||
| let error; | ||
| await page.waitForSelector('*', { waitFor: 'attached' }).catch(e => error = e); | ||
| expect(error.message).toBe('options.waitFor is not supported, did you mean options.state?'); |
pavelfeldman
force-pushed
the
waitForSelector
branch
from
9440213 to
80c85f4
Compare
dgozman
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A straw man for #2090