Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [Dependency] Update https-proxy-agent #2715

Closed
lukeed opened this issue Jun 25, 2020 · 3 comments
Closed

[BUG] [Dependency] Update https-proxy-agent #2715

lukeed opened this issue Jun 25, 2020 · 3 comments

Comments

@lukeed
Copy link
Contributor

lukeed commented Jun 25, 2020

Context:

  • Playwright Version: 1.1.1
  • Operating System: N/A
  • Node version: N/A
  • Browser: N/A
  • Extra: N/A

Describe the bug

Looking at playwright's dependency graph I noticed that it's relying on an outdated https-proxy-agent version. Because of this, there are two versions of debug installed per every install of playwright. Luckily, it's your only duplicate.

While seemingly minor, you're still relying on outdated deps.

https-proxy-agent@5.x exists – it still supports Node >= 10 and shares your debug link
@pavelfeldman
Copy link
Member

@lukeed: thanks! would you be open to sending a PR that fixes it?

@lukeed
Copy link
Contributor Author

lukeed commented Jun 25, 2020

Sure 👍

@lukeed lukeed mentioned this issue Jun 26, 2020
Closed
@aslushnikov
Copy link
Collaborator

Closed by #2777.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deps): bump https-proxy-agent version lukeed/playwright
3 participants
@aslushnikov @pavelfeldman @lukeed