Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump https-proxy-agent version #2724

Closed
wants to merge 1 commit into from

Conversation

lukeed
Copy link
Contributor

@lukeed lukeed commented Jun 26, 2020

See package's release notes

Closes #2715

@ghost
Copy link

ghost commented Jun 26, 2020

CLA assistant check
All CLA requirements met.

@pavelfeldman
Copy link
Member

Linter seems unhappy. @aslushnikov, any idea why?

@aslushnikov
Copy link
Collaborator

aslushnikov commented Jun 28, 2020

@pavelfeldman https-proxy-agent 5.0.0 comes with index.d.ts that contains the following lines:

import http from 'http';

The proper import statement is

import * as http from 'http';

The reason it works for them is because they use esModuleInterop option in their tsconfig. It looks like it doesn't work for us because we don't have this option enabled in our tsconfig?

@JoelEinbinder how do we go about this? I'm confused.

@JoelEinbinder
Copy link
Contributor

@JoelEinbinder how do we go about this? I'm confused.

We can just enable esModuleInterop if nothing else breaks? I'll try it out.

@aslushnikov
Copy link
Collaborator

Closing in favor of #2777

@lukeed
Copy link
Contributor Author

lukeed commented Jun 30, 2020

Not sure why that couldn't have been pushed into here.

@lukeed lukeed deleted the chore/https-proxy branch June 30, 2020 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Dependency] Update https-proxy-agent
4 participants