Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fonts do not applied in Chromium if use page.route() before mount() #27294

Closed
RiceWithMeat opened this issue Sep 25, 2023 · 1 comment · Fixed by #27429
Closed

[BUG] Fonts do not applied in Chromium if use page.route() before mount() #27294

RiceWithMeat opened this issue Sep 25, 2023 · 1 comment · Fixed by #27429
Assignees
@dgozman
Labels
v1.39

Comments

@RiceWithMeat
Copy link

System info

  • Playwright Version: [v1.38]
  • Operating System: [macOS 13.2.1]
  • Browser: [Chromium]

If use page.route() before component mount(), fonts will not load in Chromium. Other CSS applied correctly.
I ran same test in Safari and all CSS works fine.

Link to the GitHub repository with the repro

https://github.com/RiceWithMeat/playwright-ct-fonts-bug

Expected

Montserrat font used for h1

Actual

Times New Roman used for h1
@yury-s
Copy link
Member

yury-s commented Sep 25, 2023 •
edited
Loading

Debugging notes: this is another manifestation of https://bugs.chromium.org/p/chromium/issues/detail?id=1279953. We receive two Fetch.requestPaused for the same request id and resume it only once.

Related issue: #12148

@yury-s yury-s added the v1.39 label Sep 25, 2023
@yury-s yury-s self-assigned this Sep 25, 2023
@dgozman dgozman assigned dgozman and unassigned yury-s Oct 3, 2023
@dgozman dgozman mentioned this issue Oct 4, 2023
Merged
yury-s pushed a commit that referenced this issue Oct 4, 2023
@dgozman
fix(chromium): continue requests paused for the second time (#27429)
d426f2f 
Sometimes Chromium restarts requests. This leads to multiple
`Fetch.requestPaused` for a single `Network.requestWillBeSent`.

Fixes #27294.
@dgozman dgozman mentioned this issue Oct 9, 2023
Merged
dgozman added a commit that referenced this issue Oct 10, 2023
@dgozman
fix(chromium): avoid premature continue of redirects (#27520)
2407041 
This has recently regressed in #27429.

We now continue requests that are paused for the second time. However,
redirects share `networkId` with the original request, so we may confuse
paused redirect with a second pause for the original request.

This is covered by the flaky test `page-route.spec.ts:392 > should work
with redirects for subresources`
References #27294.
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this issue Oct 27, 2023
@dgozman @Germandrummer92
fix(chromium): continue requests paused for the second time (microsof…
94cc09f 
…t#27429)

Sometimes Chromium restarts requests. This leads to multiple
`Fetch.requestPaused` for a single `Network.requestWillBeSent`.

Fixes microsoft#27294.
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this issue Oct 27, 2023
@dgozman @Germandrummer92
fix(chromium): avoid premature continue of redirects (microsoft#27520)
eebff05 
This has recently regressed in microsoft#27429.

We now continue requests that are paused for the second time. However,
redirects share `networkId` with the original request, so we may confuse
paused redirect with a second pause for the original request.

This is covered by the flaky test `page-route.spec.ts:392 > should work
with redirects for subresources`
References microsoft#27294.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgozman dgozman

Labels
v1.39
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(chromium): continue requests paused for the second time dgozman/playwright
3 participants
@yury-s @dgozman @RiceWithMeat