Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevOps] GitHub Dependency graph does not work #4320

Closed
mxschmitt opened this issue Nov 3, 2020 · 5 comments
Closed

[DevOps] GitHub Dependency graph does not work #4320

mxschmitt opened this issue Nov 3, 2020 · 5 comments

Comments

@mxschmitt
Copy link
Member

Since we generate our package.json files for the main and sub-packages on-demand with a script, they are not in the repository.

It would be cool if we could create maybe a dummy folder with a minimal one for the packages, so that GitHub can pick it up and shows us a number and which projects are using it.

Example: https://github.com/playwright-community/jest-playwright/network/dependents?package_id=UGFja2FnZS04NjcyNjkyMjc%3D

@arjunattam

@JoelEinbinder
Copy link
Contributor

Will dummy files work or do we need the correct dependencies in these package.jsons? We could publish the generated ones. It would be yet another script to add to npm watch. @pavelfeldman

@mxschmitt
Copy link
Member Author

Will dummy files work or do we need the correct dependencies in these package.jsons? We could publish the generated ones. It would be yet another script to add to npm watch. @pavelfeldman

I think the best would be if it would contain the real dependenciee too (like mirror them), then they will be shown too. I would see potential value in this and it seems easy to add.

@mxschmitt
Copy link
Member Author

Would be good to know, maybe ask the folks at GitHub what the minimum requirement is to have the feature to work, I tried:

@mxschmitt
Copy link
Member Author

Opened a GitHub support ticket 928291 for it, try to get more requirements whats needed out of it.

aslushnikov pushed a commit that referenced this issue Dec 10, 2020
Relates #4320

The support suggest something like that.

(does not close because we want to verify it works before)
@mxschmitt
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants