Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] screencast tests fail on Mac10.14 #6439

Closed
aslushnikov opened this issue May 6, 2021 · 1 comment
Closed

[BUG] screencast tests fail on Mac10.14 #6439

aslushnikov opened this issue May 6, 2021 · 1 comment
Assignees
@aslushnikov

Comments

@aslushnikov
Copy link
Collaborator

Offending patch: 791443d
Failing tests: https://devops.aslushnikov.com/flakiness2.html#branch=master&browser=webkit&platform=Darwin+10.14&timestamp=1620322239924
@aslushnikov aslushnikov self-assigned this May 6, 2021
aslushnikov added a commit to aslushnikov/playwright that referenced this issue May 6, 2021
@aslushnikov
fix: use old screencast protocol calls for Mac 10.14
1af0a98 
This is a quick workaround to be cherry-picked in the release branch.
We'll align protocols in a follow-up.

References microsoft#6439
@aslushnikov aslushnikov mentioned this issue May 6, 2021
Merged
aslushnikov added a commit that referenced this issue May 6, 2021
@aslushnikov
fix: use old screencast protocol calls for Mac 10.14 (#6440)
aab602c 
This is a quick workaround to be cherry-picked in the release branch.
We'll align protocols in a follow-up.

References #6439
aslushnikov added a commit to aslushnikov/playwright that referenced this issue May 6, 2021
@aslushnikov
cherry-pick(release-1.11): use old screencast protocol calls for Mac …
6777056 
…10.14

Cherry-pick microsoft#6440, SHA aab602c

References microsoft#6439
@aslushnikov aslushnikov mentioned this issue May 6, 2021
Merged
aslushnikov added a commit to aslushnikov/playwright that referenced this issue May 6, 2021
@aslushnikov
browser(deprecated-webkit-mac-10.14): align Screencast protocol calls
244a9ce 
This patch aligns protocol calls for deprecated webkit for mac10.14 with
the tip-of-tree protocol calls.

References microsoft#6439
@aslushnikov aslushnikov mentioned this issue May 6, 2021
Closed
aslushnikov added a commit that referenced this issue May 6, 2021
@aslushnikov
cherry-pick(release-1.11): use old screencast protocol calls for Mac …
f496c65 
…10.14 (#6442)

Cherry-pick #6440, SHA aab602c

References #6439
@aslushnikov
Copy link
Collaborator Author

This is fixed now. We discussed #6445 with Yury and decided to keep the frontend approach since its tiny.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslushnikov aslushnikov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aslushnikov