Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(log): log only user api calls with DEBUG=pw:api #1029

Merged
merged 1 commit into from
Feb 25, 2020
Merged

feat(log): log only user api calls with DEBUG=pw:api #1029

merged 1 commit into from
Feb 25, 2020

Conversation

pavelfeldman
Copy link
Member

@pavelfeldman pavelfeldman commented Feb 15, 2020 •
edited
Loading

Partially addresses #1002

Screen Shot 2020-02-14 at 9 43 28 PM

@pavelfeldman pavelfeldman force-pushed the log_api branch 2 times, most recently from b853adc to b974846 Compare February 15, 2020 22:56
dgozman
dgozman reviewed Feb 18, 2020
View reviewed changes
Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice, but fails for me when running 'should provide access to the opener page' test.

@aslushnikov
Copy link
Collaborator

aslushnikov commented Feb 21, 2020 •
edited
Loading

This is very nice, but fails for me when running 'should provide access to the opener page' test.

Hmm, I believe this should mostly work, though we can code it nicer. (and it does work for me for the test)

@pavelfeldman pavelfeldman merged commit ebcaade into microsoft:master Feb 25, 2020
@pavelfeldman pavelfeldman deleted the log_api branch April 17, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelfeldman @aslushnikov @dgozman