test: update animation click test #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is this change doing? The test is still disabled? |
Yep. The test was flaky by itself, so I updated it in the hopes we can now pass it, but that revealed two issues (see the comment). |
|
Whats the plan to pass this test? |
| const animateLeft = () => { | ||
| const button = document.querySelector('button'); | ||
| button.style.left = window.atLeft ? '${containerWidth - buttonSize}px' : '0px'; | ||
| console.log('set ' + button.style.left); |
There was a problem hiding this comment.
nit: unneeded console log
| expect(await page.evaluate('window.clicked')).toBe(2); | ||
| expect(await page.evaluate('document.querySelector("#button").style.left')).toBe('0px'); | ||
| await page.evaluate(transition => { | ||
| window.setInterval(animateLeft, transition); |
There was a problem hiding this comment.
If we care specifically about the rafs, then this should probably be animated on raf right?
I'm not sure what we are testing, but if I was reviewing this code for a website I would say this is broken. You should always animate on raf, not setInterval.
Co-Authored-By: Joel Einbinder <joel.einbinder@gmail.com>
Co-Authored-By: Joel Einbinder <joel.einbinder@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.