test(navigation): fix flaky networkidle tests #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Feb 19, 2020
test/navigation.spec.js
Outdated
| frame._page.waitForRequest(server.PREFIX + suffix), | ||
| ]) | ||
| } | ||
| frame.setContent |
| const waitForRequest = suffix => { | ||
| return Promise.all([ | ||
| server.waitForRequest(suffix), | ||
| frame._page.waitForRequest(server.PREFIX + suffix), |
There was a problem hiding this comment.
I am curious why do we need to waitForRequest for the test to pass.
There was a problem hiding this comment.
I don't remember, but it is definitely required. I'll look at it again tomorrow.
There was a problem hiding this comment.
The protocol events for firefox come in a strange order if we dont await the request events on the frontend:
- requestWIllBeSent A
- responseRecieved A
- requestWillBeSent B
- requestWillBeSent C
Because A appears to be resolved before B and C are sent, networkidle2 is never trigged, and the timer resolves 500ms after the initial index.html request, not the responseRecieved A as was intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The network idle tests were waiting for requests to appear on the server, but not for playwright to be notified of the request via protocol. They also assumed performance.now would match up with setTimeout times.