feat(keyboard): support simple copy-pasting using meta+c/v #10828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
force-pushed
the
copy-pasting
branch
from
dd951cc
to
0ed3352
Compare
The keystrokes are macOS-specific, you just need to skip the test on other platforms, see this test for example. |
Andarist
force-pushed
the
copy-pasting
branch
from
0ed3352
to
cc0abb0
Compare
Andarist
force-pushed
the
copy-pasting
branch
from
cc0abb0
to
94e3c16
Compare
|
@yury-s I've applied the suggested change. One test suite is failing but it seems unrelated to this PR. q: is there no support for non-mac editing commands at all? can those kinds of tests be only written for Macs at the moment? |
aslushnikov
reviewed
Feb 9, 2022
aslushnikov
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a straightforward change to support new, common, keyboard commands
Note that I've tested this locally with Chrome on my Mac but it seems that CI doesn't want to pass Chrome tests - it's running on ubuntu though. Does this mean that I should introduce per-platform editing commands? At the moment there is only a single
macEditingCommandsfile.Fixes #12000