Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser(webkit): revert unused Target.oldTargetId #1096

Merged
merged 1 commit into from
Feb 25, 2020
Merged

browser(webkit): revert unused Target.oldTargetId #1096

merged 1 commit into from
Feb 25, 2020

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Feb 25, 2020

@aslushnikov
Copy link
Collaborator

Technically it's still used in wk; will you remove the pw-part after the roll?

@yury-s
Copy link
Member Author

yury-s commented Feb 25, 2020

Can you point at the code that depends on it ? Note that it is also passed in the didCommitProvisional target event but I'm not touching that part.

@yury-s yury-s merged commit c7ade1a into microsoft:master Feb 25, 2020
@yury-s yury-s deleted the oldTargetId branch February 25, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslushnikov aslushnikov aslushnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yury-s @aslushnikov