api(popup): introduce BrowserContext.exposeFunction #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
approved these changes
Mar 2, 2020
docs/api.md
Outdated
| - `playwrightFunction` <[function]> Callback function which will be called in Playwright's context. | ||
| - returns: <[Promise]> | ||
|
|
||
| The method adds a function called `name` on the `window` object of every page in the context. |
docs/api.md
Outdated
| ); | ||
| const page = await context.newPage(); | ||
| page.on('console', msg => console.log(msg.text())); | ||
| await page.evaluate(async () => { |
There was a problem hiding this comment.
It would be nice if md5 was used in a page context snippet.
src/page.ts
Outdated
| @@ -598,3 +556,67 @@ export class Worker extends platform.EventEmitter { | |||
| return (await this._executionContextPromise).evaluateHandle(pageFunction, ...args as any); | |||
| } | |||
| } | |||
|
|
|||
| export class PageBindng { | |||
test/evaluation.spec.js
Outdated
| @@ -274,7 +274,15 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT}) | |||
| await page.evaluate(() => { window.JSON.stringify = null; window.JSON = null; }); | |||
| const result = await page.evaluate(() => ({abc: 123})); | |||
| expect(result).toEqual({abc: 123}); | |||
| }) | |||
| }); | |||
| it.skip(WEBKIT)('should await promise from popup', async function({page, server}) { | |||
test/page.spec.js
Outdated
| @@ -385,6 +385,31 @@ module.exports.describe = function({testRunner, expect, headless, playwright, FF | |||
| }); | |||
| expect(result).toBe(36); | |||
| }); | |||
| it.skip(CHROMIUM || FFOX)('should work with browser context', async({browser, server}) => { | |||
There was a problem hiding this comment.
move this to browsercontext.spec.js
dgozman
commented
Mar 3, 2020
docs/api.md
Outdated
| - `playwrightFunction` <[function]> Callback function which will be called in Playwright's context. | ||
| - returns: <[Promise]> | ||
|
|
||
| The method adds a function called `name` on the `window` object of every page in the context. |
docs/api.md
Outdated
| ); | ||
| const page = await context.newPage(); | ||
| page.on('console', msg => console.log(msg.text())); | ||
| await page.evaluate(async () => { |
src/page.ts
Outdated
| @@ -598,3 +556,67 @@ export class Worker extends platform.EventEmitter { | |||
| return (await this._executionContextPromise).evaluateHandle(pageFunction, ...args as any); | |||
| } | |||
| } | |||
|
|
|||
| export class PageBindng { | |||
test/evaluation.spec.js
Outdated
| @@ -274,7 +274,15 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT}) | |||
| await page.evaluate(() => { window.JSON.stringify = null; window.JSON = null; }); | |||
| const result = await page.evaluate(() => ({abc: 123})); | |||
| expect(result).toEqual({abc: 123}); | |||
| }) | |||
| }); | |||
| it.skip(WEBKIT)('should await promise from popup', async function({page, server}) { | |||
test/page.spec.js
Outdated
| @@ -385,6 +385,31 @@ module.exports.describe = function({testRunner, expect, headless, playwright, FF | |||
| }); | |||
| expect(result).toBe(36); | |||
| }); | |||
| it.skip(CHROMIUM || FFOX)('should work with browser context', async({browser, server}) => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.