-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: properly publish all packages on travis #1187
Conversation
// If they are not equal - refuse to publish since | ||
// we're not tip-of-tree. | ||
const upstream_sha = execSync(`git ls-remote https://github.com/Microsoft/playwright --tags master | cut -f1`).toString('utf8'); | ||
const current_sha = execSync(`git rev-parse HEAD`).toString('utf8'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this check moved to publish_all_packages.sh
utils/publish_all_packages.sh
Outdated
exit 1 | ||
fi | ||
|
||
if [[ (-n $NPM_AUTH_TOKEN) && (! -f $HOME/.npmrc) ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra CI check
utils/publish_all_packages.sh
Outdated
exit 1 | ||
fi | ||
VERSION=$(node -e 'console.log(require("./package.json").version)') | ||
echo -n "Publish Playwright v${VERSION} (y/n)? " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: y/N
echo -n "Publish Playwright v${VERSION} (y/n)? " | |
echo -n "Publish Playwright v${VERSION} (y/N)? " |
No description provided.