New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api(popups): move Page.authenticate to BrowserContext.setHTTPCredentials #1250

Closed

dgozman wants to merge 2 commits into microsoft:master from dgozman:bc-auth

Contributor

dgozman commented Mar 5, 2020 •

edited by aslushnikov

Loading

Drive-by: fixes #720 since it rolls past r1037.

aslushnikov approved these changes

View reviewed changes

test/browsercontext.spec.js Outdated Show resolved Hide resolved

test/browsercontext.spec.js Outdated Show resolved Hide resolved


          api(popups): move Page.authenticate to BrowserContext.setHTTPCredentials

810c1ab

dgozman marked this pull request as ready for review

March 6, 2020 00:41


          use FF r1039

Collaborator

aslushnikov commented Mar 6, 2020

Closing in favor of #1267

aslushnikov closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet