Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devops: fix protocol generation with root on Linux #1327

Merged
merged 1 commit into from
Mar 10, 2020
Merged

devops: fix protocol generation with root on Linux #1327

merged 1 commit into from
Mar 10, 2020

Conversation

mxschmitt
Copy link
Member

Currently it was leading to an error if I tried to build it with a root user on a Linux environment. So in the end the type generation was just skipped:

22:51:55.757 $ node install-from-github.js
22:51:55.813 Building playwright...
22:52:14.094 chromium downloaded to /11994741/playwright/.local-chromium/linux-747023 22:52:14.123 Failed to launch browser!
22:52:14.123 [0310/215214.121201:ERROR:zygote_host_impl_linux.cc(89)] Running as root without --no-sandbox is not supported. See https://crbug.com/638180.
22:52:14.123 TROUBLESHOOTING: https://github.com/Microsoft/playwright/blob/master/docs/troubleshooting.md

Maybe we should also exit the script with an error code if the protocol generation was not successful.

@aslushnikov aslushnikov merged commit a24cce8 into microsoft:master Mar 10, 2020
@aslushnikov
Copy link
Collaborator

@mxschmitt Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants