devops: remake downloading logic #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch: - removes `browserType.downloadBrowserIfNeeded()` method. The method turned out to be ill-behaving and could not be used as we'd like to. - adds a `browserType.setExecutablePath` method to set a browser exectuable. Now, all clients of `playwright-core` should take care of downloading a browser one way or another and setting the downloaded path with the `browserType.setExecutablePath` method. The playwright object can then be returned to client.
aslushnikov
force-pushed
the
eeeeeeeeeeeee
branch
from
938f57d to
9c6ec4f
Compare
dgozman
reviewed
Mar 18, 2020
Co-Authored-By: Joel Einbinder <joel.einbinder@gmail.com>
Co-Authored-By: Joel Einbinder <joel.einbinder@gmail.com>
Co-Authored-By: Joel Einbinder <joel.einbinder@gmail.com>
Co-Authored-By: Joel Einbinder <joel.einbinder@gmail.com>
|
Am i seeing this wrong or you still downloading into node_modules? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
browserType.downloadBrowserIfNeeded()method. The methodturned out to be ill-behaving and cannot not be used as we'd like to (see [BUG] Playwright requires manual install of browsers #1085)
browserType.setExecutablePathmethod to set a browserexectuable.
With this patch, we take the following approach towards managing browser downloads:
playwright-coredoesn't download any browsers. Inplaywright-core,playwright.chromium.executablePath()returnsnull(same for firefox and webkit).playwright-core(e.g.playwrightand others) download browsers one way or another.They can then configure
playwrightwith executable paths and re-export theplaywrightobject to their clients.playwright,playwright-firefox,playwright-chromiumandplaywright-webkitdownloadbrowsers. Once browsers are downloaded, their executable paths are saved to a
.downloaded-browsers.jsonfile. This file is read inplaywright/index.jsto configure browser executable paths and re-export the API.install-from-github.jsthat also cleans up old browsers.