Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser(webkit): introduce Playwright.windowOpen protocol event #1420

Merged
merged 1 commit into from
Mar 18, 2020
Merged

browser(webkit): introduce Playwright.windowOpen protocol event #1420

merged 1 commit into from
Mar 18, 2020

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Mar 18, 2020

@yury-s
Copy link
Member

yury-s commented Mar 18, 2020

Can we fire this event from the WebProcess instead (it seems that both new page as well as the features are available in WebChromeClient::createWindow) and avoid all the plumbing to and in the UIProcess? Maybe generate something like Page.windowFeatures(features) in the new page as soon as its Page domain is enabled (we anyway pause it in createWindow).

@dgozman
Copy link
Contributor Author

dgozman commented Mar 18, 2020

Can we fire this event from the WebProcess instead (it seems that both new page as well as the features are available in WebChromeClient::createWindow) and avoid all the plumbing to and in the UIProcess? Maybe generate something like Page.windowFeatures(features) in the new page as soon as its Page domain is enabled (we anyway pause it in createWindow).

I tried that first, but it was flaky. I suspect that's due to CreateWindow being a sync IPC, and sendMessageToFrontend being async one. After changing to UIProcess, the flakiness is gone.

@dgozman dgozman merged commit bfcffbb into microsoft:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants