api(context): get rid of PageEvent #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Mar 19, 2020
src/chromium/crBrowser.ts
Outdated
| const opener = target.opener(); | ||
| if (!opener) | ||
| return; | ||
| // Opener page must have been initialized already and resumed in order to | ||
| // create this popup, maybe use opener._crPage!.page()? |
There was a problem hiding this comment.
Yeah, we can use _initializedPage.
There was a problem hiding this comment.
On the second thought I believe there is a slight chance of race: the opener page may have been fully initialized (and resumed) in the browser but playwright didn't receive all responses yet, child page may be created and initialized before the response comes. Leaving the code as is to allow for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.