fix(chromium): support main resource request interception for popups #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
force-pushed
the
main-request-interception
branch
from
ec30e95 to
8ac3c1d
Compare
pavelfeldman
approved these changes
Mar 20, 2020
dgozman
approved these changes
Mar 20, 2020
| // Main resource request for the page is being intercepted so the Frame is not created | ||
| // yet. Precreate it here for the purposes of request interception. It will be updated | ||
| // later as soon as the request contnues and we receive frame tree from the page. | ||
| frame = this._page._frameManager.frameAttached(event.frameId, null); |
There was a problem hiding this comment.
I am a bit worried about this (user can call request.frame().url() and be surprised, or even try to evaluate in it), but oh well.
There was a problem hiding this comment.
Let's see, if it becomes a problem we can put additional protection to ensure the page will throw meaningful errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.