feat(lang): emulate language on firefox #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
fe_lang2
branch
2 times, most recently
from
6776ea5 to
2b4155b
Compare
aslushnikov
reviewed
Mar 21, 2020
| @@ -308,7 +308,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF | |||
| expect(await page.evaluate(() => navigator.language)).toBe('fr-CH'); | |||
| await context.close(); | |||
| }); | |||
| it('should format number', async({browser, server}) => { | |||
| it.fail(FFOX)('should format number', async({browser, server}) => { | |||
There was a problem hiding this comment.
why doesn't this work?
There was a problem hiding this comment.
We need to patch builtins w/ locale data.
aslushnikov
approved these changes
Mar 21, 2020
dgozman
reviewed
Mar 21, 2020
src/firefox/ffBrowser.ts
Outdated
| if (this._options.locale) { | ||
| if (!this._options.extraHTTPHeaders) | ||
| this._options.extraHTTPHeaders = {}; | ||
| this._options.extraHTTPHeaders['Accept-Language'] = this._options.locale; |
There was a problem hiding this comment.
I think we should leave options.extraHTTPHeaders as is and instead update FFBrowserContext.setExtraHTTPHeaders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.