test: make debugp collect IO #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/playwright.spec.js
Outdated
| state.browser._setDebugFunction(onLine); | ||
| } | ||
|
|
||
| let rl; | ||
| if (state.browserServer.process().stderr) { |
There was a problem hiding this comment.
this already happens here. I guess you want stdout as well, you can add it there.
test/playwright.spec.js
Outdated
| @@ -113,8 +113,11 @@ module.exports.describe = ({testRunner, product, playwrightPath}) => { | |||
|
|
|||
| beforeEach(async(state, test) => { | |||
| const onLine = (line) => test.output += line + '\n'; | |||
| if (dumpProtocolOnFailure) | |||
| if (dumpProtocolOnFailure) { | |||
| state.browserServer.process().stdout.on('data', onLine); | |||
There was a problem hiding this comment.
stdout might be null on the process is somebody set dumpio=true.
test/browsercontext.spec.js
Outdated
| @@ -422,7 +422,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, FF | |||
| await context.close(); | |||
| }); | |||
| // flaky: https://github.com/microsoft/playwright/pull/1301/checks?check_run_id=496478707 | |||
| it.fail(FFOX && LINUX)('should fail if wrong credentials', async({browser, server}) => { | |||
| fit('should fail if wrong credentials', async({browser, server}) => { | |||
There was a problem hiding this comment.
Suggested change
| fit('should fail if wrong credentials', async({browser, server}) => { | |
| it.fail(FFOX && LINUX)('should fail if wrong credentials', async({browser, server}) => { |
pavelfeldman
force-pushed
the
debugp
branch
2 times, most recently
from
a3f9025 to
b91f5eb
Compare
| @@ -207,7 +207,8 @@ class Reporter { | |||
| console.log(`${prefix} ${colors.red(`[TIMEOUT ${test.timeout}ms]`)} ${test.fullName} (${formatLocation(test.location)})`); | |||
| if (test.output) { | |||
| console.log(' Output:'); | |||
| console.log(padLines(test.output, 4)); | |||
| for (const line of test.output) | |||
There was a problem hiding this comment.
This will indent poorly if a line of output is multiline.
There was a problem hiding this comment.
I'd like to be consistent with requre('debug')
There was a problem hiding this comment.
previously I could do test.output += JSON.stringify(obj, undefined, 2). Now I can't without breaking the indent.
There was a problem hiding this comment.
We were never putting anything from stdio there at the first place, let's see how it looks first
| @@ -207,7 +207,8 @@ class Reporter { | |||
| console.log(`${prefix} ${colors.red(`[TIMEOUT ${test.timeout}ms]`)} ${test.fullName} (${formatLocation(test.location)})`); | |||
| if (test.output) { | |||
| console.log(' Output:'); | |||
| console.log(padLines(test.output, 4)); | |||
| for (const line of test.output) | |||
| console.log(' ' + line); | |||
There was a problem hiding this comment.
Suggested change
| console.log(' ' + line); | |
| console.log(padLines(line, 4)); |
There was a problem hiding this comment.
These are different things
JoelEinbinder
approved these changes
Mar 23, 2020
pavelfeldman
force-pushed
the
debugp
branch
3 times, most recently
from
5965e27 to
d762557
Compare
pavelfeldman
added a commit
that referenced
this pull request
Mar 23, 2020
This reverts commit b1bebda.
pavelfeldman
added a commit
to pavelfeldman/playwright
that referenced
this pull request
Mar 23, 2020
This reverts commit b1bebda.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.