test: fix firefox-beta tests #16278
Merged
test: fix firefox-beta tests #16278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Aug 5, 2022
tests/config/browserTest.ts
Outdated
| @@ -54,12 +54,12 @@ const test = baseTest.extend<BrowserTestTestFixtures, BrowserTestWorkerFixtures> | |||
| }, { scope: 'worker' } ], | |||
|
|
|||
| allowsThirdParty: [async ({ browserName, browserMajorVersion, channel }, run) => { | |||
| if (browserName !== 'firefox') | |||
| if (browserName === 'firefox' && channel === '') | |||
Follow-up to fb76d62 that has a buggy fixture implementation.
aslushnikov
force-pushed
the
fix-ff-beta-tests
branch
from
c85e188 to
3b579c8
Compare
mxschmitt
pushed a commit
to mxschmitt/playwright
that referenced
this pull request
Aug 10, 2022
This was referenced Sep 4, 2022
Open
Open
Open
This was referenced Sep 9, 2022
Open
Open
Open
Open
This was referenced Sep 15, 2022
Open
Open
Open
Open
This was referenced Sep 21, 2022
Open
Open
This was referenced Sep 24, 2022
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to fb76d62 that has a buggy
fixture implementation.