Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: another test for baseUrl/relative imports (#15891) #16338

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

denis-sokolov
Copy link
Contributor

A failing test for #15891, this seems to have found the cause of the problem: existing directory at the top level with the same name.

@ghost
Copy link

ghost commented Aug 8, 2022

CLA assistant check
All CLA requirements met.

Copy link
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome test, thank you!

tests/playwright-test/resolver.failing.spec.ts Outdated Show resolved Hide resolved
tests/playwright-test/resolver.failing.spec.ts Outdated Show resolved Hide resolved
@denis-sokolov denis-sokolov force-pushed the additional-test-for-15891 branch from 7f10161 to 90a0a05 Compare August 8, 2022 16:41
@denis-sokolov
Copy link
Contributor Author

@pavelfeldman, addressed your comments. The failing checks are unrelated and I don’t have the “retry” button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants