-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(codegen): make sure input recording with japanese IME Work #16400
Merged
mxschmitt
merged 1 commit into
microsoft:main
from
mxschmitt:do-925de8da2b599f061889d808ba73ff535b39a9f4
Aug 10, 2022
Merged
fix(codegen): make sure input recording with japanese IME Work #16400
mxschmitt
merged 1 commit into
microsoft:main
from
mxschmitt:do-925de8da2b599f061889d808ba73ff535b39a9f4
Aug 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kawasaki.taiga <kigtaiga@gmail.com> Co-authored-by: Max Schmitt <max@schmitt.mx>
Merging without approval since already lgtm on the actual PR by Yury. |
mxschmitt
added a commit
to mxschmitt/playwright
that referenced
this pull request
Aug 10, 2022
… with japanese IME Work SHA: 699a52e
Rumatoid
pushed a commit
to Rumatoid/playwright-main
that referenced
this pull request
Aug 11, 2022
… with japanese IME Work (microsoft#16414) SHA: 699a52e
This was referenced Sep 4, 2022
Open
Open
Open
This was referenced Sep 9, 2022
Open
Open
Open
Open
This was referenced Sep 15, 2022
Open
Open
Open
Open
This was referenced Sep 21, 2022
Open
Open
Open
Open
Open
This was referenced Sep 27, 2022
Open
Open
Open
This was referenced Oct 6, 2022
Open
Open
This was referenced Oct 9, 2022
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #16210 (comment) reland with formatting fixes.