docs(dotnet): document unsupported Parallelizable attributes on Nunit #16471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
reviewed
Aug 12, 2022
|
Can we add a similar section for MSTest? |
Co-authored-by: Max Schmitt <max@schmitt.mx>
…thub.com/kblok/playwright into docs-dotnet-nunit-Parallelizable-support
|
Done @mxschmitt |
mxschmitt
reviewed
Aug 12, 2022
docs/src/test-runners-csharp.md
Outdated
| @@ -58,6 +60,10 @@ public class MyTest : PageTest | |||
| } | |||
| ``` | |||
|
|
|||
| :::note | |||
There was a problem hiding this comment.
can we move it under the "### Running NUnit tests in Parallel" heading and don't have a Note for it? So its like the mstest one. Thanks!
Rest lgtm.
There was a problem hiding this comment.
How about now @mxschmitt ?
mxschmitt
approved these changes
Aug 12, 2022
github-actions bot
added a commit
that referenced
this pull request
Aug 15, 2022
…tributes in NUnit/MSTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/microsoft/playwright-dotnet/issues/
I'm clarifying what the valid options for
Parallelizableare.