fix(docs): fix snippets, integrate navigations to ToC and core concepts #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
approved these changes
Apr 20, 2020
docs/core-concepts.md
Outdated
| @@ -75,16 +75,35 @@ const context = await browser.newContext({ | |||
|
|
|||
| <br/> | |||
|
|
|||
| ## Pages and frames | |||
| ## Pages, frames and navigation | |||
There was a problem hiding this comment.
I'd leave as is. User will not pick this because they were interested in 'navigation'.
docs/core-concepts.md
Outdated
| const page = await context.newPage(); | ||
| ``` | ||
|
|
||
| A page can be used to navigate to URLs and then interact with contents. You don't usually need to worry about navigation and can focus on the interaction. |
docs/core-concepts.md
Outdated
| const page = await context.newPage(); | ||
| ``` | ||
|
|
||
| A page can be used to navigate to URLs and then interact with contents. You don't usually need to worry about navigation and can focus on the interaction. |
There was a problem hiding this comment.
Drop "You don't usually need to worry about navigation and can focus on the interaction." If I don't need to worry, as you said.
docs/core-concepts.md
Outdated
| @@ -104,6 +123,7 @@ await frame.fill('#username-input', 'John'); | |||
|
|
|||
| - [class `Page`](./api.md#class-page) | |||
| - [class `Frame`](./api.md#class-frame) | |||
| - [Navigation and loading](loading.md) | |||
There was a problem hiding this comment.
It is very easy for me to assume this is a link to the api.md and never click it. Do "To learn more about page navigation and loading, read this document".
|
All done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.