test: fix flaky cookie roundtrip test #19459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flakiness dashboard reveals on Window's variants of Chromium, the decimal for actual vs. expected was slightly off (e.g. 1705568002.677066 vs. 1705568002.674173). This test fix assumes it's acceptable to suppress the roundrip floating point difference (which appears to be constrained to Windows).
dgozman
approved these changes
Dec 14, 2022
Co-authored-by: Dmitry Gozman <dgozman@gmail.com> Signed-off-by: Ross Wollman <rwoll@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flakiness dashboard reveals on Window's variants of Chromium, the decimal for actual vs. expected was slightly off (e.g. 1705568002.677066 vs. 1705568002.674173).
This test fix assumes it's acceptable to suppress the roundrip floating point difference (which appears to be constrained to Windows).