Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api(waitFor): remove waitFor, use specialized wait functions #1995

Merged
merged 1 commit into from
Apr 27, 2020
Merged

api(waitFor): remove waitFor, use specialized wait functions #1995

merged 1 commit into from
Apr 27, 2020

Conversation

pavelfeldman
Copy link
Member

Fixes #1993

mxschmitt
mxschmitt reviewed Apr 27, 2020
View reviewed changes
package-lock.json
@@ -1,6 +1,6 @@
{
"name": "playwright-core",
"version": "1.0.0-post",
"version": "0.15.0-post",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that seems not intended

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather 1.0.0 was not intended, it was too early :)

@pavelfeldman pavelfeldman merged commit 7f8aa70 into microsoft:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt left review comments

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] waitFor() with string for selectorOrFunctionOrTimeout - return of JSHandle or ElementHandle
3 participants
@pavelfeldman @dgozman @mxschmitt