chore: read browser revisions off package.json #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
revisions
branch
2 times, most recently
from
b42c890 to
c7d206b
Compare
aslushnikov
reviewed
Apr 28, 2020
package.json
Outdated
| "firefox_revision": "1087", | ||
| "webkit_revision": "1211" | ||
| }, | ||
| "browsers": [ |
There was a problem hiding this comment.
how do you feel about moving browser config out to a separate file? This way we'd avoid abusing
package.json
There was a problem hiding this comment.
My understanding is that this is what package.json is for :)
aslushnikov
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.