fix: make sure transform cache is world-writable #21947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Mar 24, 2023
| // Make sure we create cache folders with 777 permissions. | ||
| // Based on the stackoveflow answer: https://stackoverflow.com/a/34721366/314883 | ||
| // See https://github.com/microsoft/playwright/issues/21859 | ||
| const oldmask = process.umask(0); |
There was a problem hiding this comment.
Why don't we do this once at the start of the test runner, and not only here? We create quite a few directories.
| // Based on the stackoveflow answer: https://stackoverflow.com/a/34721366/314883 | ||
| // See https://github.com/microsoft/playwright/issues/21859 | ||
| const oldmask = process.umask(0); | ||
| fs.mkdirSync(path.dirname(cachePath), { recursive: true, mode: 0o777 }); |
There was a problem hiding this comment.
Perhaps a helper that we will use everywhere?
|
I'm worried that this makes it possible that user1 can modify the transpiled code of user2. |
oh year, we decided against this and will use different folders, prefixed with username. PR is coming soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21859