chore(ct): throw error when props are not json serializable #22025
Conversation
sand4rt
force-pushed
the
ct-jsonv-props-check
branch
from
0b3258b
to
57175cb
Compare
sand4rt
force-pushed
the
ct-jsonv-props-check
branch
from
57175cb
to
a1d6506
Compare
| boolean: (value: any) => typeof value === 'boolean', | ||
| null: (value: any) => value === null, | ||
| array: (value: any) => Array.isArray(value) && value.every(isJson), | ||
| object: (value: any) => typeof value === 'object' && value !== null && !Array.isArray(value) |
There was a problem hiding this comment.
JSON will have a default serializing conventions for types like Date, but I guess it is Ok to be more restrictive here.
There was a problem hiding this comment.
Not sure if i fully get that. Thought only the string, number, boolean, null, array and object types are JSON serializable? Do you mean that JSON.parse(JSON.stringify({ boop: Date })) will return {} ?
There was a problem hiding this comment.
Look at what JSON.stringify({ data: new Date() }) produces, but don't bother.
Done, also added the check for |
sand4rt
force-pushed
the
ct-jsonv-props-check
branch
from
95ccaa6
to
1683fe5
Compare
sand4rt
force-pushed
the
ct-jsonv-props-check
branch
from
1683fe5
to
2e2c67b
Compare
Related to: #21400, #22003