Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added envinfo to the bug issue template #2237

Merged
merged 2 commits into from
Aug 28, 2020

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented May 14, 2020

Fixes #2027

Can be merged as soon a new version of envinfo is released.

@thernstig
Copy link
Contributor

Is there any sense in leaving the **Context:** parts now? All answers answered by the npx command can be removed from there. The only thing that needs to stay in some sense is the "browsers" and "extras". Would it be possible to merge the npx part with the Context part to be less verbose?

(Verbose bug report templates scare people)

@thernstig
Copy link
Contributor

Should this still stay in some way?

- Browser: [e.g. All, Chromium, Firefox, WebKit]

npx won't give that information, which I assume is quite important for Playwright bugs?

@pavelfeldman
Copy link
Member

It is saying

No "playwright" preset found.

to me

@mxschmitt
Copy link
Member Author

It is saying

No "playwright" preset found.

to me

Yep that's why the PR is in draft and as mentioned in the PR description we have to wait that the new update will be published.

@arjunattam
Copy link
Contributor

I think we can merge this now!

➜  ~ npx envinfo --preset playwright
npx: installed 1 in 0.993s

  System:
    OS: macOS 10.15.6
    Memory: 2.61 GB / 32.00 GB
  Binaries:
    Node: 14.5.0 - /usr/local/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.5 - /usr/local/bin/npm
  Languages:
    Bash: 3.2.57 - /bin/bash

@mxschmitt
Copy link
Member Author

I think we can merge this now!

➜  ~ npx envinfo --preset playwright
npx: installed 1 in 0.993s

  System:
    OS: macOS 10.15.6
    Memory: 2.61 GB / 32.00 GB
  Binaries:
    Node: 14.5.0 - /usr/local/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.5 - /usr/local/bin/npm
  Languages:
    Bash: 3.2.57 - /bin/bash

Yep, made one follow up PR, so the output gets:


  System:
    OS: macOS 10.15.6
    Memory: 1.18 GB / 16.00 GB
  Binaries:
    Node: 13.12.0 - /var/folders/nq/zpr698s164v26n4v45mfkzw80000gq/T/yarn--1598600290051-0.6392841704017853/node
    Yarn: 1.22.4 - /var/folders/nq/zpr698s164v26n4v45mfkzw80000gq/T/yarn--1598600290051-0.6392841704017853/yarn
    npm: 6.14.4 - ~/.nvm/versions/node/v13.12.0/bin/npm
  Languages:
    Bash: 3.2.57 - /bin/bash
  npmPackages:
    playwright-chromium: 1.3.0 => 1.3.0 
    playwright-video: 2.3.1 => 2.3.1 

@mxschmitt mxschmitt marked this pull request as ready for review August 28, 2020 07:46
Copy link
Contributor

@arjunattam arjunattam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited to make it more terse

@arjunattam arjunattam merged commit c2cd963 into microsoft:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Usage of envinfo to supply information in bug reports
4 participants