chore(build): switch to babel for compiling typescript #2341
Conversation
|
Wouldn't babel run the same typescript compiler with the generate-only options? Why bringing it in? |
Where is the generate-only option? |
| @@ -15,14 +15,14 @@ | |||
| */ | |||
|
|
|||
| export { Accessibility } from './accessibility'; | |||
| export { Browser } from './browser'; | |||
| export { BrowserContext } from './browserContext'; | |||
| export { BrowserBase as Browser } from './browser'; | |||
There was a problem hiding this comment.
These don't look like improvements either
There was a problem hiding this comment.
These fix bugs in apicoverage.spec.js. Previously we were exporting a type, which got stripped by TypeScript.
I think we are waiting on microsoft/TypeScript#29651 |
|
Yeah, looks like Babel is generating code on its own there. Isn't it scary though? I'd be more comfortable with not bringing more tools into the game. What's broken? We need to ignore the errors from the first build pass? Does not sound like a big deal. Maybe protocol generation should be a part of the roll process instead? |
Babel + TypeScript is a very standard workflow. I trust Babel just as much if not more than TypeScript to compile our code. Especially since we currently use TypeScript to convert our code to be compatible with Node 10.
I received complaints about the current setup. We can stick with it and it will be mostly fine. I'll send a separate patch to fix the coverage. The problem with ignoring errors is that we don't know which errors are safe to ignore. A syntax error in the code will fail silently and run the library from the previous commit.
I don't like committing generated files when I can help it. I find they inevitably end up out of date with the code that generates them. |
This is different. You commit chrome.exe and protocol is a part of it. You are right in that we should not commit files that are generated from our source, but this is not a part of our source. |
In my mode, there is no building at all |
This patch adds babel, which is used to transform our TypeScript into JavaScript. The main difference is that types are not checked during build. This removes the cyclical dependency we had where the types were required to build, but a built playwright was required to generate the types. It also makes building faster by a few seconds.
As a bonus, this exposed a bug where we were exporting some types instead of classes in
api.ts. This causedBrowserandBrowserContextto be excluded from the automated coverage tests.