Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(steps): only propagate soft errors up the hierarchy #24054

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix(steps): only propagate soft errors up the hierarchy #24054

merged 1 commit into from
Jul 5, 2023

Conversation

pavelfeldman
Copy link
Member

Fixes #23979

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

"tests 1" report.

@pavelfeldman pavelfeldman merged commit 566b277 into microsoft:main Jul 5, 2023
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
@pavelfeldman @Germandrummer92
fix(steps): only propagate soft errors up the hierarchy (microsoft#24054
4f14a44 
)

Fixes microsoft#23979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslushnikov aslushnikov aslushnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Step is marked as failed despite it's passed (when try/catch block is used)
2 participants
@pavelfeldman @aslushnikov