browser(firefox): another way to report elements without layout object #2597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous attempt was wrong for visibility:hidden elements, and also for zero-sized elements like <br>. This one should match other browsers.
yury-s
approved these changes
Jun 17, 2020
| if (!rect) | ||
| rect = { x: -1, y: -1, width: -1, height: -1}; | ||
| if (unsafeObject.scrollRectIntoViewIfNeeded) | ||
| unsafeObject.scrollRectIntoViewIfNeeded(rect.x, rect.y, rect.width, rect.height); | ||
| else | ||
| throw new Error('Node type does not support scrollRectIntoViewIfNeeded'); | ||
| throw new Error('Node does not have a layout object'); |
There was a problem hiding this comment.
We should change the wording here to something more clear, what is layout object?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous attempt was wrong for visibility:hidden elements, and also for zero-sized elements like
<br>. This one should match other browsers.