devops: do cache busting for APT #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid caching old package lists, every `apt-get install` should be prefixed with `apt-get update`. More info on the matter: - https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#apt-get - moby/moby#3313
mxschmitt
reviewed
Jun 20, 2020
|
Agreed, we should probably combine all apt installs into one because apt-get update is not the fastest step and calling it multiple times slows down no-cache build(probably insignificantly but still:), at the same time whenever we add a new dependency we want everything to be consistent and up to date. I believe the only reason of the split commands is readability which we could achieve with proper formatting. In any case could be done in a separate PR if you prefer. |
yury-s
approved these changes
Jun 20, 2020
aslushnikov
added a commit
that referenced
this pull request
Jul 14, 2020
This adds a new script to calculate docker image size with all parent layers. Note: take this metrics with a grain of salt, since in reality docker compresses and reuses layers. Some historic stats obtained with this script: - **`208MB`** (-33MB) chore(docker): skip "recommended" dependencies (#2917) (1cebf87) - **`241MB`** (-29MB) chore(docker): trim some of the gstreamer dependencies (#2897) (bce4b1a) - **`272MB`** (-1MB) devops: do cache busting for APT (#2656) (bb34418) - **`273MB`** (+49MB) fix(webkit): update Docker file to include gstreamer (#2636) (5c6c659) - **`224MB`** (+0MB) chore: fix emojis for CR and FF in Dockerfile (#2522) (24316ad) - **`224MB`** (-1MB) fix: Dockerfile for Firefox (#1937) (b516ac4) - **`225MB`** (+49MB) devops(docker): Install ffmpeg dependency, adding codecs necessary for video playback in Firefox (#1627) (222d01c) - **`176MB`** (+32MB) chore(docs): optionally install XVFB in docker(ec3ee66) - **`144MB`** (+144MB) feat: add a playwright-ready docker image (#1161)(1781ae7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid caching old package lists, every
apt-get installshould be prefixed with
apt-get update.More info on the matter: