fix(textContent): make page.textContent(selector) atomic #2717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
approved these changes
Jun 25, 2020
We now query selector and take textContent synchronously. This avoids any issues with async processing: node being recycled, detached, etc. More methods will follow with the same atomic pattern. Drive-by: fixed selector engine names being sometimes case-sensitive and sometimes not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now query selector and take textContent synchronously. This avoids any issues with async processing: node being recycled, detached, etc.
For this, some infrastructure has been moved to dom.ts. More methods will follow with the same atomic pattern and reuse it.
Drive-by: fixed selector engine names being sometimes case-sensitive and sometimes not.