chore(rpc): clear the page test spec #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Jun 27, 2020
src/rpc/client/browserContext.ts
Outdated
| @@ -162,7 +165,8 @@ export class BrowserContext extends ChannelOwner<BrowserContextChannel, BrowserC | |||
| } | |||
|
|
|||
| async waitForEvent(event: string, optionsOrPredicate?: Function | (types.TimeoutOptions & { predicate?: Function })): Promise<any> { | |||
| return waitForEvent(this, event, optionsOrPredicate); | |||
| const hasTimeout = optionsOrPredicate && !(optionsOrPredicate instanceof Function); | |||
| return waitForEvent(this, event, optionsOrPredicate, this._timeoutSettings.timeout(hasTimeout ? optionsOrPredicate as any : {})); | |||
There was a problem hiding this comment.
Shouldn't we do _pendingWaitForEvents here as well?
| return result; | ||
| return Promise.race([ | ||
| result, | ||
| new Promise((f, r) => setTimeout(() => r(new TimeoutError('Timeout while waiting for event')), timeout)) |
There was a problem hiding this comment.
Don't forget to clearTimeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.