Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support alternative quotes in js parseLocator() #27718

Merged
merged 1 commit into from
Oct 20, 2023
Merged

feat: support alternative quotes in js parseLocator() #27718

merged 1 commit into from
Oct 20, 2023

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Oct 20, 2023

Fixes #27707.

@github-actions
Copy link
Contributor

Test results for "tests 1"

7 flaky ⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/chromium/oopif.spec.ts:329:3 › should not throw on exposeFunction when oopif detaches
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › page/page-event-request.spec.ts:162:3 › should return response body when Cross-Origin-Opener-Policy is set
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:167:5 › should update tracing network live

25917 passed, 603 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit 6fe31ab into microsoft:main Oct 20, 2023
30 checks passed
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
@dgozman @Germandrummer92
feat: support alternative quotes in js parseLocator() (microsoft#27718)
5ded763 
Fixes microsoft#27707.
@dgozman dgozman mentioned this pull request Jan 16, 2024
Merged
dgozman added a commit that referenced this pull request Jan 17, 2024
@dgozman
fix(locator parser): allow escaped quotes in the digest function (#29012
d023829 
)

This supports mixed quotes locators in JavaScript where we are not sure
what quote is the correct one, so we normalize to unescaped single quote
when comparing with the original.

Drive-by: we were allowing single quotes in Python, Java and .NET, but
these are actually not allowed.

Regressed in #27718.
Fixes #28630.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Inspector Locator Picker doesn't work with double quoted strings which contain single quotes
2 participants
@dgozman @mxschmitt