browser(webkit): force wpe to use the complex text path #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WPE targets a wide range of embedded hardware SoCs, some of them don't have a very performant CPU, like the first generations of Raspberry Pi for instance. So yeah I'd agree with enabling this in Playwright, but keep in mind it might introduce performance issues if you run Playwright on low-end hardware. |
yury-s
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #2626, this forces WPE to use the complex text path which causes symbol fonts to work.
@philn You had concerns about performance. Is this potentially worse than the GTK performance? As long as it doesn't cripple the browser I think rendering fonts correctly for us is more important than rendering them fast.